netdev - Re: [PATCH] NET : keep sk_backlog near sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 04 Mar 2007 16:05:57 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dada1@...mosbay.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] NET : keep sk_backlog near sk_lock

From: Eric Dumazet <dada1@...mosbay.com>
Date: Thu, 22 Feb 2007 15:50:15 +0100

> sk_backlog is a critical field of struct sock. (known famous words)
> 
> It is (ab)used in hot paths, in particular in release_sock(), tcp_recvmsg(), 
> tcp_v4_rcv(), sk_receive_skb().
> 
> It really makes sense to place it next to sk_lock, because sk_backlog is only 
> used after sk_lock locked (and thus memory cache line in L1 cache). This 
> should reduce cache misses and sk_lock acquisition time.
> 
> (In theory, we could only move the head pointer near sk_lock, and leaving tail 
> far away, because 'tail' is normally not so hot, but keep it simple :) )
> 
> Signed-off-by: Eric Dumazet <dada1@...mosbay.com>

Applied, thanks a lot Eric.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html