netdev - Re: [PATCH, RESEND] chelsio: Fix non-NAPI compile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 26 Feb 2007 15:00:00 -0800
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	Roland Dreier <rdreier@...co.com>
Cc:	Jeff Garzik <jgarzik@...ox.com>, netdev@...r.kernel.org
Subject: Re: [PATCH, RESEND] chelsio: Fix non-NAPI compile

On Mon, 26 Feb 2007 14:58:49 -0800
Roland Dreier <rdreier@...co.com> wrote:

> Chelsio without NAPI enabled has been broken (won't compile) since
> 3de00b89 ("chelsio: NAPI speed improvement"):
> 
>     drivers/net/chelsio/sge.c: In function `t1_interrupt`:
>     drivers/net/chelsio/sge.c:1716: error: `Q` undeclared (first use in this function)
> 
> The change below seems to add back in the declaration and
> initialization of `Q` that was removed by mistake, and at least makes
> the driver compile for me, although I have no hardware and hence no
> way to test whether this actually works.
> 
> Signed-off-by: Roland Dreier <rolandd@...co.com>
> ---
> Jeff, I haven't seen any response from Stephen but Divy from Chelsio
> seemed to agree with this patch, so can you please merge it?  Right
> now the build is broken with CONFIG_CHELSIO_T1_NAPI=n.
> 
> Thanks.
> 
> 

I agree it was an obvious goof.

-- 
Stephen Hemminger <shemminger@...ux-foundation.org>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html