lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 27 Feb 2007 17:53:28 +0100 From: Patrick McHardy <kaber@...sh.net> To: Jan-Bernd Themann <ossthema@...ibm.com> CC: Jeff Garzik <jeff@...zik.org>, netdev <netdev@...r.kernel.org>, Christoph Raisch <raisch@...ibm.com>, Jan-Bernd Themann <themann@...ibm.com>, linux-kernel <linux-kernel@...r.kernel.org>, linux-ppc <linuxppc-dev@...abs.org>, Marcus Eder <meder@...ibm.com>, Thomas Klein <tklein@...ibm.com>, Stefan Roscher <stefan.roscher@...ibm.com> Subject: Re: [PATCH 2/2] ehea: NAPI multi queue TX/RX path for SMP Jan-Bernd Themann wrote: > This patch provides a functionality that allows parallel > RX processing on multiple RX queues by using dummy netdevices. > > > +static inline int ehea_hash_skb(struct sk_buff *skb, int num_qps) > +{ > + u32 tmp; > + if ((skb->nh.iph->protocol == IPPROTO_TCP) > + && skb->protocol == ETH_P_IP) { skb->protocol has network byte order. The ETH_P_IP test should also logically come before checking the IP protocol. > + tmp = (skb->h.th->source + (skb->h.th->dest << 16)) % 31; Only locally generated packets have a valid h.th pointer. > + tmp += skb->nh.iph->daddr % 31; > + return tmp % num_qps; > + } > + else > + return 0; > +} > + > static int ehea_start_xmit(struct sk_buff *skb, struct net_device *dev) > { > struct ehea_port *port = netdev_priv(dev); > @@ -1796,9 +1818,18 @@ static int ehea_start_xmit(struct sk_buf > unsigned long flags; > u32 lkey; > int swqe_index; > - struct ehea_port_res *pr = &port->port_res[0]; > + struct ehea_port_res *pr; > + > + pr = &port->port_res[ehea_hash_skb(skb, port->num_tx_qps)]; > + - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists