lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <200702281023.17591.ossthema@de.ibm.com> Date: Wed, 28 Feb 2007 10:23:16 +0100 From: Jan-Bernd Themann <ossthema@...ibm.com> To: Patrick McHardy <kaber@...sh.net> Cc: Jeff Garzik <jeff@...zik.org>, netdev <netdev@...r.kernel.org>, Christoph Raisch <raisch@...ibm.com>, Jan-Bernd Themann <themann@...ibm.com>, linux-kernel <linux-kernel@...r.kernel.org>, linux-ppc <linuxppc-dev@...abs.org>, Marcus Eder <meder@...ibm.com>, Thomas Klein <tklein@...ibm.com>, Stefan Roscher <stefan.roscher@...ibm.com> Subject: Re: [PATCH 2/2] ehea: NAPI multi queue TX/RX path for SMP Hi, > > > > +static inline int ehea_hash_skb(struct sk_buff *skb, int num_qps) > > +{ > > + u32 tmp; > > + if ((skb->nh.iph->protocol == IPPROTO_TCP) > > + && skb->protocol == ETH_P_IP) { > > skb->protocol has network byte order. The ETH_P_IP test should also > logically come before checking the IP protocol. > fixed. > > + tmp = (skb->h.th->source + (skb->h.th->dest << 16)) % 31; > > Only locally generated packets have a valid h.th pointer. > good point. I'll fix that. I'll send a new patch set later today Thanks, Jan-Bernd - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists