netdev - Re: [patch 3/6] [TULIP] fix for Lite-On 82c168 PNIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45F96460.8020804@garzik.org>
Date:	Thu, 15 Mar 2007 11:21:04 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Valerie Henson <val_henson@...ux.intel.com>
CC:	akpm@...l.org, netdev@...r.kernel.org,
	Guido Classen <classeng@...gi.de>,
	Grant Grundler <grundler@...isc-linux.org>
Subject: Re: [patch 3/6] [TULIP]  fix for Lite-On 82c168 PNIC

Valerie Henson wrote:
> From: Guido Classen <classeng@...gi.de>
> 
> This small patch fixes two issues with the Lite-On 82c168 PNIC adapters.
> I've tested it with two cards in different machines both chip rev 17
> 
> The first is the wrong register address CSR6 for writing the MII register
> which instead is 0xB8 (this may get a symbol too?) (see similar exisiting code
> at line 437) in tulip_core.c
> 
> [Double-checked by Val Henson; yes, 0xB8 is correct register for
> autonegotiate on this card.]
> 
> At least by my cards, the the bit 31 from the MII register seems to be
> somewhat unstable. This results in reading wrong values from the Phy-Registers
> und prevents the card from correct initialization. I've added a litte delay
> and an second test of the bit. If the bit is stil cleared the read/write
> process has definitely finished.
> 
> [Original patch slightly massaged by Val Henson]
> 
> Signed-off-by: Val Henson <val_henson@...ux.intel.com>
> Cc: Guido Classen <classeng@...gi.de>
> Signed-off-by: Grant Grundler <grundler@...isc-linux.org>
> Cc: Jeff Garzik <jeff@...zik.org>
> 
> ---
>  drivers/net/tulip/media.c      |   31 +++++++++++++++++++++++++++----
>  drivers/net/tulip/tulip_core.c |    4 ++--
>  2 files changed, 29 insertions(+), 6 deletions(-)

Seems sane, but now on HOLD while it's being discussed


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html