netdev - Re: [patch 4/6] [TULIP] Quiet down tulip_stop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45F96556.10205@garzik.org>
Date:	Thu, 15 Mar 2007 11:25:10 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Valerie Henson <val_henson@...ux.intel.com>
CC:	akpm@...l.org, netdev@...r.kernel.org,
	Grant Grundler <grundler@...isc-linux.org>
Subject: Re: [patch 4/6] [TULIP]  Quiet down tulip_stop_rxtx

Valerie Henson wrote:
> Only print out debugging info for tulip_stop_rxtx if debug is on.
> Many cards (including at least two of my own) fail to stop properly
> during initialization according to this test with no apparent ill
> effects.  Worse, it tends to spam logs when the driver doesn't work.
> 
> Signed-off-by: Val Henson <val_henson@...ux.intel.com>
> Signed-off-by: Grant Grundler <grundler@...isc-linux.org>
> Cc: Jeff Garzik <jeff@...zik.org>
> 
> ---
>  drivers/net/tulip/tulip.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- pristine-linux.orig/drivers/net/tulip/tulip.h
> +++ pristine-linux/drivers/net/tulip/tulip.h
> @@ -481,7 +481,7 @@ static inline void tulip_stop_rxtx(struc
>  		while (--i && (ioread32(ioaddr + CSR5) & (CSR5_TS|CSR5_RS)))
>  			udelay(10);
>  
> -		if (!i)
> +		if (!i && (tulip_debug > 1))
>  			printk(KERN_DEBUG "%s: tulip_stop_rxtx() failed"
>  					" (CSR5 0x%x CSR6 0x%x)\n",
>  					pci_name(tp->pdev),

Here's the problem with this:  this printk is signalling that the DMA 
engines have not yet stopped, which is an event of which we should be wary.

While it makes sense to do this patch, since the complaining cards 
appear to work anyway, we also need to take into account the times when 
this is not a spurious warning.

Thus, I would consider maybe adding a warning somewhere in the 
DMA-engine-start region of code, that complains if the DMA engines are 
already active, or somesuch.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html