netdev - Re: [PATCH 3/5] AF_RXRPC: Make it possible to merely try to cancel timers and delayed work [try #2]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <25539.1174054929@redhat.com>
Date:	Fri, 16 Mar 2007 14:22:09 +0000
From:	David Howells <dhowells@...hat.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, herbert.xu@...hat.com,
	linux-kernel@...r.kernel.org, hch@...radead.org,
	arjan@...radead.org
Subject: Re: [PATCH 3/5] AF_RXRPC: Make it possible to merely try to cancel timers and delayed work [try #2] 

Alan Cox <alan@...rguk.ukuu.org.uk> wrote:

> > +static inline int try_to_cancel_delayed_work(struct delayed_work *work)
> > +{
> > +	int ret;
> 
> This expands to a fair bit of code and IMHO isn't an inline candidate.

Then why is cancel_delayed_work() inline?  It's very similar in terms of
expansion.

And it's not a fair bit of code.  try_to_cancel_delayed_work() is out of line,
and work_release() is just clear_bit() in disguise.

David
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html