netdev - Re: Oops in filter add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <45FF8602.8040108@trash.net>
Date:	Tue, 20 Mar 2007 07:58:10 +0100
From:	Patrick McHardy <kaber@...sh.net>
To:	hadi@...erus.ca
CC:	David Miller <davem@...emloft.net>, chris@...lexsecurity.com,
	netdev@...r.kernel.org, tgraf@...g.ch
Subject: Re: Oops in filter add

jamal wrote:
> On Mon, 2007-19-03 at 19:22 -0700, David Miller wrote:
> 
>>It looks like the idea might have been to allow more parallelized
>>running of ingress filters, but this is done wrong and leads to
>>the crashes you are seeing.
> 
> 
> The main idea is to avoid one BigLock for both ingress and egress;
> Which was/is still useful in the compat mode where netfilter is used
> instead. 


In that case is isn't even used.

>>Can you just replace the above with dev->queue_lock and see if
>>that makes your problem go away?  THanks.
> 
> 
> It should; 
> i will stare at the code later and see if i can send a better patch,
> maybe a read_lock(qdisc_tree_lock).


You would need to make qdisc_lock_tree() aware of the difference
between ingress and egress.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html