netdev - Re: [PATCH -rt] Fix initialization of spinlock in irttp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 21 Mar 2007 08:11:13 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Deepak Saxena <dsaxena@...xity.net>
Cc:	samuel@...tiz.org, netdev@...r.kernel.org,
	Andrew Morton <akpm@...l.org>,
	Daniel Walker <dwalker@...sta.com>
Subject: Re: [PATCH -rt] Fix initialization of spinlock in irttp_dup()


* Deepak Saxena <dsaxena@...xity.net> wrote:

> This was found around the 2.6.10 timeframe when testing with the -rt 
> patch and I believe is still is an issue. irttp_dup() does a memcpy() 
> of the tsap_cb structure causing the spinlock protecting various 
> fields in the structure to be duped.  This works OK in the non-RT case 
> but in the RT case we end up with two mutexes pointing to the same 
> wait_list and leading to an OOPS. Fix is to simply initialize the 
> spinlock after the memcpy().

note that memcpy based lock initialization is a problem for lockdep too.

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html