netdev - Re: Fix return code in pci-skeleton.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46036A82.1080600@garzik.org>
Date:	Fri, 23 Mar 2007 01:49:54 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Anton Blanchard <anton@...ba.org>
CC:	netdev@...r.kernel.org
Subject: Re: Fix return code in pci-skeleton.c

Anton Blanchard wrote:
> We assign the return value of register_netdev to i, but return rc later
> on. Fix it.
> 
> Signed-off-by: Anton Blanchard <anton@...ba.org>
> ---
> 
> diff --git a/drivers/net/pci-skeleton.c b/drivers/net/pci-skeleton.c
> index 00ca0fd..6ca4e4f 100644
> --- a/drivers/net/pci-skeleton.c
> +++ b/drivers/net/pci-skeleton.c
> @@ -710,8 +710,8 @@ match:
>  		tp->chipset,
>  		rtl_chip_info[tp->chipset].name);
>  
> -	i = register_netdev (dev);
> -	if (i)
> +	rc = register_netdev (dev);
> +	if (rc)
>  		goto err_out_unmap;

applied


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html