netdev - Re: [PATCH 1/5 2.6.21-rc4] l2tp: pppol2tp core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <460561E3.9020502@katalix.com>
Date:	Sat, 24 Mar 2007 17:37:39 +0000
From:	James Chapman <jchapman@...alix.com>
To:	Florian Zumbiehl <florz@....de>
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH 1/5 2.6.21-rc4] l2tp: pppol2tp core

Florian Zumbiehl wrote:
> Hi,
> 
>> + * 251003 :	Copied from pppoe.c version 0.6.9.
> 
> you might want to have a look at the patches to the PPPoE code that were
> posted to netdev recently, as some of them seem to apply to code that's
> left over from pppoe.c.

Do you mean this change?

  * 070228 : Fix to allow multiple sessions with same remote MAC and same
  *	    session id by including the local device ifindex in the
  *	    tuple identifying a session. This also ensures packets can't
  *          be injected into a session from interfaces other than the
  *          one	specified by userspace. Florian Zumbiehl <florz@....de>

The pppoe session hash table isn't used in the pppol2tp code so the 
above change doesn't affect pppol2tp. I rechecked the latest pppoe.c and 
I don't see other changes that haven't already been incorporated in 
pppol2tp. Which specific code in pppol2tp do you think needs to be updated?

Thanks

-- 
James Chapman
Katalix Systems Ltd
http://www.katalix.com
Catalysts for your Embedded Linux software development

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html