lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 26 Mar 2007 23:08:24 -0400 (EDT)
From:	James Morris <jmorris@...ei.org>
To:	Joy Latten <latten@...tin.ibm.com>
cc:	netdev@...r.kernel.org, davem@...emloft.net, eparis@...hat.com
Subject: Re: [PATCH]: Add security check before flushing SAD/SPD

On Mon, 26 Mar 2007, Joy Latten wrote:

> 
> Sending again since one of the email addresses was incorrect.
> 
> ----------------
> 
> Ok, I have made improvements based on James' and Eric's comments.
> 

Acked-by: James Morris <jmorris@...ei.org>


> +			if (xfrm_id_proto_match(x->id.proto, proto) &&
> +			   (err = security_xfrm_state_delete(x)) != 0) {


Still not a showstopper, but standard idiom would be nice at some point.



- James
-- 
James Morris
<jmorris@...ei.org>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists