netdev - Re: [PATCH 1/3] [NET] fib_rules: goto rule action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <460899D3.60808@osdl.org>
Date:	Mon, 26 Mar 2007 21:13:07 -0700
From:	Stephen Hemminger <shemminger@...l.org>
To:	David Miller <davem@...emloft.net>
CC:	tgraf@...g.ch, netdev@...r.kernel.org
Subject: Re: [PATCH 1/3] [NET] fib_rules: goto rule action

David Miller wrote:
> From: Thomas Graf <tgraf@...g.ch>
> Date: Tue, 27 Mar 2007 01:54:51 +0200
>
>   
>> This patch adds a new rule action FR_ACT_GOTO which allows
>> to skip a set of rules by jumping to another rule. The rule
>> to jump to is specified via the FRA_GOTO attribute which
>> carries a rule preference.
>>
>> Referring to a rule which doesn't exists is explicitely allowed.
>> Such goto rules are marked with the flag FIB_RULE_UNRESOLVED
>> and will act like a rule with a non-matching selector. The rule
>> will become functional as soon as its target is present.
>>
>> The goto action enables performance optimizations by reducing
>> the average number of rules that have to be passed per lookup.
>>
>> Example:
>> 0:      from all lookup local 
>> 40:     not from all to 192.168.23.128 goto 32766
>> 41:     from all fwmark 0xa blackhole
>> 42:     from all fwmark 0xff blackhole
>> 32766:  from all lookup main 
>>
>> Signed-off-by: Thomas Graf <tgraf@...g.ch>
>>     
>
> This looks excellent, applied to net-2.6.22, thanks Thomas.
> -
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>   

Do we have to worry about self inflicted infinite loops?
Shouldn't there be some way to some basic validation?

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html