[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20070328.121405.49244759.davem@davemloft.net>
Date: Wed, 28 Mar 2007 12:14:05 -0700 (PDT)
From: David Miller <davem@...emloft.net>
To: ilpo.jarvinen@...sinki.fi
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH] [TCP]: Rexmit hint must be cleared instead of setting
it
From: David Miller <davem@...emloft.net>
Date: Wed, 28 Mar 2007 12:07:09 -0700 (PDT)
> From: "Ilpo_Järvinen" <ilpo.jarvinen@...sinki.fi>
> Date: Wed, 28 Mar 2007 16:31:50 +0300 (EEST)
>
> > Stupid error from my side. Even though now that I noticed this,
> > I hoped it would have been an optimization but no, the counter
> > hint is then incorrect. Thus clearing is necessary for now (I
> > still suspect though that this path is never executed).
> >
> > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>
>
> Better safe than sorry :-)
>
> We can start putting more aggressive assertions around if you'd
> like to get some invariants like that validated.
In case it's not clear I did apply this patch.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists