netdev - Re: [PATCH] [TCP]: Rexmit hint must be cleared instead of setting it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0703282223540.29833@kivilampi-30.cs.helsinki.fi>
Date:	Wed, 28 Mar 2007 22:29:05 +0300 (EEST)
From:	"Ilpo Järvinen" <ilpo.jarvinen@...sinki.fi>
To:	David Miller <davem@...emloft.net>
cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] [TCP]: Rexmit hint must be cleared instead of setting
 it

On Wed, 28 Mar 2007, David Miller wrote:

> From: David Miller <davem@...emloft.net>
> Date: Wed, 28 Mar 2007 12:07:09 -0700 (PDT)
> 
> > From: "Ilpo_Järvinen" <ilpo.jarvinen@...sinki.fi>
> > Date: Wed, 28 Mar 2007 16:31:50 +0300 (EEST)
> > 
> > > Stupid error from my side. Even though now that I noticed this,
> > > I hoped it would have been an optimization but no, the counter
> > > hint is then incorrect. Thus clearing is necessary for now (I
> > > still suspect though that this path is never executed).
> > > 
> > > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>
> > 
> > Better safe than sorry :-)
> > 
> > We can start putting more aggressive assertions around if you'd
> > like to get some invariants like that validated.
> 
> In case it's not clear I did apply this patch.

I think more this on Friday, maybe WARN_ON could be placed there so that 
no harm is being done if it ever get there, probably a candidate for 
unlikely, if this is really needed. Anyway, applying the NULL this patch 
does no harm (it was supposed to be that way right from the
beginning)... :-)

...but lets keep in mind that the actual goal is, of course, to get rid of 
the hint altogether, rather than doing these clearing things... :-)

-- 
 i.