netdev - Re: net nasties in davem's tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070329.190602.116354248.davem@davemloft.net>
Date:	Thu, 29 Mar 2007 19:06:02 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	akpm@...ux-foundation.org
Cc:	netdev@...r.kernel.org
Subject: Re: net nasties in davem's tree

From: David Miller <davem@...emloft.net>
Date: Thu, 29 Mar 2007 19:03:17 -0700 (PDT)

> From: Andrew Morton <akpm@...ux-foundation.org>
> Date: Thu, 29 Mar 2007 18:37:30 -0700
> 
> > drivers/net/3c523.c: In function 'elmc_send_packet':
> > drivers/net/3c523.c:1148: warning: passing argument 2 of 'skb_copy_from_linear_data' discards qualifiers from pointer target type
> > drivers/net/ni52.c: In function 'ni52_send_packet':
> > drivers/net/ni52.c:1185: warning: passing argument 2 of 'skb_copy_from_linear_data' discards qualifiers from pointer target type
> 
> We should probably mark the "to" argument to skb_copy_from_linear_data()
> as const, I'll take care of that.
> 
> Thanks for the report.

My bad, what's going on in the first case is the driver
has "volatile disease".  I'll add back the (char *) cast
that was in the original memcpy().
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html