netdev - [PATCH] fix MCA when shutting down tulip quad-NIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070403211916.GA25570@aepfle.de>
Date:	Tue, 3 Apr 2007 23:19:16 +0200
From:	Olaf Hering <olaf@...fle.de>
To:	val_henson@...ux.intel.com, andrew.patterson@...com,
	netdev@...r.kernel.org
Subject: [PATCH] fix MCA when shutting down tulip quad-NIC

From: andrew.patterson@...com

 https://bugzilla.novell.com/show_bug.cgi?id=SUSE39204

Shutting down the network causes an MCA because of an IO TLB error when
a DEC quad 10/100 card is in any slot.  This problem was originally seen
on an HP rx4640.


Signed-off-by: Olaf Hering <olaf@...fle.de>

---

Andrew: Why is it tp->pdev instead of pdev?

 drivers/net/tulip/tulip_core.c |    1 +
 1 file changed, 1 insertion(+)

Index: b/drivers/net/tulip/tulip_core.c
===================================================================
--- a/drivers/net/tulip/tulip_core.c
+++ b/drivers/net/tulip/tulip_core.c
@@ -1798,6 +1798,7 @@ static void __devexit tulip_remove_one (
 		return;
 
 	tp = netdev_priv(dev);
+	pci_disable_device(tp->pdev);
 	unregister_netdev(dev);
 	pci_free_consistent (pdev,
 			     sizeof (struct tulip_rx_desc) * RX_RING_SIZE +
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html