lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 5 Apr 2007 14:34:17 -0700
From:	Valerie Henson <>
To:	Olaf Hering <>
Subject: Re: [PATCH] fix MCA when shutting down tulip quad-NIC

On Tue, Apr 03, 2007 at 11:19:16PM +0200, Olaf Hering wrote:
> From:

Wow, registering for Novell's bugzilla is painful.  And in the end I
get "Access denied" on that bug.  Can you give us this information
some other way?

> Shutting down the network causes an MCA because of an IO TLB error when
> a DEC quad 10/100 card is in any slot.  This problem was originally seen
> on an HP rx4640.

I'm not clear on why pci_disable_device() would fix this bug.  Do you
have an explanation (or can copy one out of the bug report)?  I'm
hesitant to make even obviously correct changes to the tulip driver
without good evidence, given the incredible variety of buggy hardware
out there.

This looks to me like another iteration of the shutdown DMA/irq race
at first glance.  Grant has a patch for it; I'm working on one I
consider cleaner.


> Signed-off-by: Olaf Hering <>
> ---
> Andrew: Why is it tp->pdev instead of pdev?

>  drivers/net/tulip/tulip_core.c |    1 +
>  1 file changed, 1 insertion(+)
> Index: b/drivers/net/tulip/tulip_core.c
> ===================================================================
> --- a/drivers/net/tulip/tulip_core.c
> +++ b/drivers/net/tulip/tulip_core.c
> @@ -1798,6 +1798,7 @@ static void __devexit tulip_remove_one (
>  		return;
>  	tp = netdev_priv(dev);
> +	pci_disable_device(tp->pdev);
>  	unregister_netdev(dev);
>  	pci_free_consistent (pdev,
>  			     sizeof (struct tulip_rx_desc) * RX_RING_SIZE +
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists