netdev - Re: [NET]: Get rid of NETIF_F_INTERNAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1176293751.14322.14.camel@localhost.localdomain>
Date:	Wed, 11 Apr 2007 22:15:51 +1000
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Herbert Xu <herbert@...dor.apana.org.au>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	Jeff Garzik <jgarzik@...ox.com>
Subject: Re: [NET]: Get rid of NETIF_F_INTERNAL_STATS

On Wed, 2007-04-11 at 17:56 +1000, Herbert Xu wrote:
> Hi:
> 
> [NET]: Get rid of NETIF_F_INTERNAL_STATS
> 
> The recently added NETIF_F_INTERNAL_STATS isn't very useful.  If the
> device driver needs to set it then it can always override get_stats
> instead.  All existing drivers that have stats (which should be every
> one) will override get_stats anyway.  Those that don't have stats
> (if there are any) wouldn't hurt from having a get_stats that just
> returns zeros everywhere.

Actually, I did this precisely because I really didn't want to start
exposing bogus stats in /proc/net/dev.  An audit might clarify if this
is an actual issue.

> So we can simply get rid of this flag.
> 
> This also fixes a potential crash in those get_stats callers that
> don't check for a NULL return value (e.g., /proc/net/dev).

Hmm, I thought it did that in my original patch?

Rusty.


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html