lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 11 Apr 2007 22:23:17 +1000
From:	Herbert Xu <>
To:	Rusty Russell <>
Cc:	"David S. Miller" <>,,
	Jeff Garzik <>
Subject: Re: [NET]: Get rid of NETIF_F_INTERNAL_STATS

On Wed, Apr 11, 2007 at 10:15:51PM +1000, Rusty Russell wrote:
> Actually, I did this precisely because I really didn't want to start
> exposing bogus stats in /proc/net/dev.  An audit might clarify if this
> is an actual issue.

Fair enough.  Still returning zeros when get_stats isn't available
would seem safe enough.  I wasn't able to find any drivers which
didn't have get_stats.

> > This also fixes a potential crash in those get_stats callers that
> > don't check for a NULL return value (e.g., /proc/net/dev).
> Hmm, I thought it did that in my original patch?

Sorry, I was looking at the wrong tree.

Visit Openswan at
Email: Herbert Xu ~{PmV>HI~} <>
Home Page:
PGP Key:
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists