netdev - Re: [NET]: Get rid of NETIF_F_INTERNAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070411122317.GA21159@gondor.apana.org.au>
Date:	Wed, 11 Apr 2007 22:23:17 +1000
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	Jeff Garzik <jgarzik@...ox.com>
Subject: Re: [NET]: Get rid of NETIF_F_INTERNAL_STATS

On Wed, Apr 11, 2007 at 10:15:51PM +1000, Rusty Russell wrote:
> 
> Actually, I did this precisely because I really didn't want to start
> exposing bogus stats in /proc/net/dev.  An audit might clarify if this
> is an actual issue.

Fair enough.  Still returning zeros when get_stats isn't available
would seem safe enough.  I wasn't able to find any drivers which
didn't have get_stats.

> > This also fixes a potential crash in those get_stats callers that
> > don't check for a NULL return value (e.g., /proc/net/dev).
> 
> Hmm, I thought it did that in my original patch?

Sorry, I was looking at the wrong tree.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html