netdev - Re: [PATCH] Add support for running the Marvell m88e1111 PHY in RGMII mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 11 Apr 2007 16:36:49 -0500
From:	Kim Phillips <kim.phillips@...escale.com>
To:	Lennert Buytenhek <buytenh@...tstofly.org>
Cc:	netdev@...r.kernel.org, jgarzik@...ox.com
Subject: Re: [PATCH] Add support for running the Marvell m88e1111 PHY in
 RGMII mode

On Wed, 11 Apr 2007 03:01:58 +0200
Lennert Buytenhek <buytenh@...tstofly.org> wrote:

> On Tue, Apr 10, 2007 at 04:57:23PM -0500, Kim Phillips wrote:
> 
> > also adds RX & TX delay bits to help boards with clock skew
> > problems.
> 
<snip>
> 
> > [...]
> > +
> > +		temp |= (MII_M1111_RX_DELAY | MII_M1111_TX_DELAY);
> 
> Enabling this unconditionally is just wrong.
> 

I agree.  There needs to be a way for the platform code to communicate
board specific quirkiness to the phylib (I just haven't figured out how
to yet).

Kim
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html