netdev - Re: [PATCH] Add support for running the Marvell m88e1111 PHY in RGMII mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070412004315.GD15021@xi.wantstofly.org>
Date:	Thu, 12 Apr 2007 02:43:15 +0200
From:	Lennert Buytenhek <buytenh@...tstofly.org>
To:	Kim Phillips <kim.phillips@...escale.com>
Cc:	netdev@...r.kernel.org, jgarzik@...ox.com
Subject: Re: [PATCH] Add support for running the Marvell m88e1111 PHY in RGMII mode

On Wed, Apr 11, 2007 at 04:36:49PM -0500, Kim Phillips wrote:

> > On Tue, Apr 10, 2007 at 04:57:23PM -0500, Kim Phillips wrote:
> > 
> > > also adds RX & TX delay bits to help boards with clock skew
> > > problems.
> > 
> <snip>
> > 
> > > [...]
> > > +
> > > +		temp |= (MII_M1111_RX_DELAY | MII_M1111_TX_DELAY);
> > 
> > Enabling this unconditionally is just wrong.
> 
> I agree.  There needs to be a way for the platform code to
> communicate board specific quirkiness to the phylib

(I'm not sure whether it's really a quirk, as the RGMII spec allows
both modes.)


> (I just haven't figured out how to yet).

Maybe offer separate RGMII and RGMII-ID[*] mode choices?


[*] RGMII with Internal Delay (RGMII specification nomenclature)
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html