netdev - Re: [PATCH net-2.6.22 1/3] [TCP]: Sed magic converts func(sk, tp, ...) -> func(sk, ...)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46238B13.5070201@trash.net>
Date:	Mon, 16 Apr 2007 16:41:23 +0200
From:	Patrick McHardy <kaber@...sh.net>
To:	Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>
CC:	Christoph Hellwig <hch@...radead.org>, netdev@...r.kernel.org,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH net-2.6.22 1/3] [TCP]: Sed magic converts func(sk, tp,
 ...) -> func(sk, ...)

Ilpo Järvinen wrote:
> Tweaked newlines manually & fixed four warnings that were
> introduced.

Not all of them it seems:

> -static inline void tcp_fast_path_check(struct sock *sk, struct tcp_sock *tp)
> +static inline void tcp_fast_path_check(struct sock *sk)
>  {
> +	struct tcp_sock *tp = tcp_sk(sk);

^ missing newline

>  	if (skb_queue_empty(&tp->out_of_order_queue) &&
>  	    tp->rcv_wnd &&
>  	    atomic_read(&sk->sk_rmem_alloc) < sk->sk_rcvbuf &&
> @@ -778,18 +779,19 @@ static inline void tcp_minshall_update(s
>  		tp->snd_sml = TCP_SKB_CB(skb)->end_seq;
>  }
>  
> -static inline void tcp_check_probe_timer(struct sock *sk, struct tcp_sock *tp)
> +static inline void tcp_check_probe_timer(struct sock *sk)
>  {
> +	struct tcp_sock *tp = tcp_sk(sk);

^ same here .. quite a few follow

>  	const struct inet_connection_sock *icsk = inet_csk(sk);
>  	if (!tp->packets_out && !icsk->icsk_pending)
>  		inet_csk_reset_xmit_timer(sk, ICSK_TIME_PROBE0,
>  					  icsk->icsk_rto, TCP_RTO_MAX);
>  }
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html