netdev - Re: [PATCH net-2.6.22 1/3] [TCP]: Sed magic converts func(sk, tp, ...) -> func(sk, ...)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0704161758020.28337@kivilampi-30.cs.helsinki.fi>
Date:	Mon, 16 Apr 2007 18:15:54 +0300 (EEST)
From:	"Ilpo Järvinen" <ilpo.jarvinen@...sinki.fi>
To:	Patrick McHardy <kaber@...sh.net>
cc:	Christoph Hellwig <hch@...radead.org>, netdev@...r.kernel.org,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH net-2.6.22 1/3] [TCP]: Sed magic converts func(sk, tp,
 ...) -> func(sk, ...)

On Mon, 16 Apr 2007, Patrick McHardy wrote:

> Ilpo Järvinen wrote:
> > Tweaked newlines manually & fixed four warnings that were
> > introduced.
> 
> Not all of them it seems:
> 
> > -static inline void tcp_fast_path_check(struct sock *sk, struct tcp_sock *tp)
> > +static inline void tcp_fast_path_check(struct sock *sk)
> >  {
> > +	struct tcp_sock *tp = tcp_sk(sk);
> 
> ^ missing newline

...in the other (original) patch description that is not copied fully here 
I had a sort of disclaimer for these missing ones but in case they should 
all be changed so that if the added tcp_sock is the only local variable I 
can do that of course... It's not clear to me what is really the preferred 
style considering all the variants... E.g., tcp_check_probe_timer (below) 
does not have the newline before this patch either?!? :-) ...tried to look 
from CodingStyle too but it didn't give any light to this thing...

> >  	if (skb_queue_empty(&tp->out_of_order_queue) &&
> >  	    tp->rcv_wnd &&
> >  	    atomic_read(&sk->sk_rmem_alloc) < sk->sk_rcvbuf &&
> > @@ -778,18 +779,19 @@ static inline void tcp_minshall_update(s
> >  		tp->snd_sml = TCP_SKB_CB(skb)->end_seq;
> >  }
> >  
> > -static inline void tcp_check_probe_timer(struct sock *sk, struct tcp_sock *tp)
> > +static inline void tcp_check_probe_timer(struct sock *sk)
> >  {
> > +	struct tcp_sock *tp = tcp_sk(sk);
> 
> ^ same here .. quite a few follow
> 
> >  	const struct inet_connection_sock *icsk = inet_csk(sk);

...No newline should be place here, since it's being followed by 
another local variable defination.

> >  	if (!tp->packets_out && !icsk->icsk_pending)
> >  		inet_csk_reset_xmit_timer(sk, ICSK_TIME_PROBE0,
> >  					  icsk->icsk_rto, TCP_RTO_MAX);
> >  }
> 

-- 
 i.