netdev - Re: [PATCH] Eliminate some unnecessary gotos in tcp v4 hash handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 20 Apr 2007 17:16:14 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	ak@...e.de
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] Eliminate some unnecessary gotos in tcp v4 hash
 handling

From: Andi Kleen <ak@...e.de>
Date: Thu, 5 Apr 2007 12:48:44 +0200

> The compiler eliminates them anyways and this makes the code easier to read
> and shorter.
> 
> Signed-off-by: Andi Kleen <ak@...e.de>

It depends upon who you ask :-)

For someone trying to verify "all code paths lead to foo and
therefore release resources and drop locks" it's always better
to use a goto to some common unwind handler at the end of
the function, regardless of what the compiler does with it.

When you're doing such an audit, return statements in the middle
of the function are red flags and make the audit more difficult.
:-)

But in these cases it's just straight returns and there are no
resources to release so I'll apply this patch, thanks!
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html