lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Fri, 20 Apr 2007 17:20:59 -0700 (PDT)
From:	David Miller <>
Subject: Re: [PATCH] Eliminate some unnecessary gotos in tcp v4 hash

From: Andi Kleen <>
Date: Thu, 5 Apr 2007 12:48:44 +0200

> The compiler eliminates them anyways and this makes the code easier to read
> and shorter.
> Signed-off-by: Andi Kleen <>

Actually I won't apply this patch, ever, -ENOCOMPILE.

Andi, please spare me with these patches if you won't even bother
trying to compile them.  It doesn't matter how easy to read the code
is if it doesn't build. :-/

I found this build failure just by reviewing your patch for
correctness, I didn't even need to give it to the compiler to see that
you left the "cur = NULL; goto out;" case in there yet removed the
"out" label.

Don't bother posting the fixed version, I'll ignore it.  You just
basically proved how pointless this patch is, and how little you
yourself even care about it.
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists