netdev - Re: [PATCH 2/5 2.6.21-rc7] l2tp: pppol2tp changes to existing ppp kernel headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070423162158.9449.qmail@farnsworth.org>
Date:	23 Apr 2007 09:21:58 -0700
From:	"Dale Farnsworth" <dale@...nsworth.org>
To:	jchapman@...alix.com, netdev@...r.kernel.org
Subject: Re: [PATCH 2/5 2.6.21-rc7] l2tp: pppol2tp changes to existing ppp kernel headers

James Chapman wrote:
> [L2TP]: Modify kernel headers for L2TP.

Since the Subject: line becomes the first line of the commit comments,
the above line is redundant.

> This patch adds L2TP definitions to existing PPP and socket headers.
> 
> Signed-off-by: James Chapman <jchapman@...alix.com>
> 
> ---
> 
> Add struct sockaddr_pppol2tp to carry L2TP-specific address
> information for the PPPoX (PPPoL2TP) socket. Unfortunately we can't
> use the union inside struct sockaddr_pppox because the L2TP-specific
> data is larger than the current size of the union and we must preserve
> the size of struct sockaddr_pppox for binary compatibility.
> 
> Also add an ioctl to allow userspace to obtain L2TP counters and state
> from the kernel.

In my opinion, the above info is sufficiently useful to be included
commit comments.

-Dale Farnsworth
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html