netdev - Re: [PATCH 2/5 2.6.21-rc7] l2tp: pppol2tp changes to existing ppp kernel headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20070430.000849.55725376.davem@davemloft.net>
Date:	Mon, 30 Apr 2007 00:08:49 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jchapman@...alix.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 2/5 2.6.21-rc7] l2tp: pppol2tp changes to existing ppp
 kernel headers

From: James Chapman <jchapman@...alix.com>
Date: Mon, 23 Apr 2007 17:01:03 +0100

> Index: linux-2.6.21-rc7/include/linux/if_pppox.h
> ===================================================================
> --- linux-2.6.21-rc7.orig/include/linux/if_pppox.h
> +++ linux-2.6.21-rc7/include/linux/if_pppox.h
> @@ -18,7 +18,19 @@
>  
>  
>  #include <asm/types.h>
> +#ifdef __KERNEL__
>  #include <asm/byteorder.h>
> +#else
> +#include <endian.h>
> +#include <byteswap.h>
> +#if __BYTE_ORDER == __LITTLE_ENDIAN
> +#define __LITTLE_ENDIAN_BITFIELD
> +#elif __BYTE_ORDER == __BIG_ENDIAN
> +#define __BIG_ENDIAN_BITFIELD
> +#else
> +#error "Adjust your <endian.h> defines."
> +#endif
> +#endif

Please don't do this, doubly especially without a changelog comment
explaining why.

No other kernel header has to accomodate userland issues like this, so
please find another way that doesn't involve crapping up the in-kernel
header files.

Thanks.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html