netdev - Re: [PATCH 3/9] wext: remove dead debug code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070427005549.GB25332@tuxdriver.com>
Date:	Thu, 26 Apr 2007 20:55:49 -0400
From:	"John W. Linville" <linville@...driver.com>
To:	Jean Tourrilhes <jt@....hp.com>
Cc:	Johannes Berg <johannes@...solutions.net>,
	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	linux-wireless@...r.kernel.org
Subject: Re: [PATCH 3/9] wext: remove dead debug code

On Thu, Apr 26, 2007 at 09:46:32AM -0700, Jean Tourrilhes wrote:

> 	Overall ok with the patches. Comments on a few of them...
> 	I personally would not remove this DEBUG code, because it
> decreases the overall maitainability of the code.
> 	First, it does not only help to debug the API, but it can be
> used to debug userspace and drivers in some extreme cases.
> 	Second, this debugging act as documentation. He points out
> which are the important variables and how they are used at critical
> points of the code.
> 	As this debug is localised, and compiled out, it does not
> bother anybody and should stay.

Jean,

I think the code looks cleaner with the patch applied.  If the
debugging is valuable to you, I recommend that you save this patch
and reverse apply it before future work.

Thanks,

John
-- 
John W. Linville
linville@...driver.com
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html