| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20070427005013.GA25332@tuxdriver.com> Date: Thu, 26 Apr 2007 20:50:13 -0400 From: "John W. Linville" <linville@...driver.com> To: Jean Tourrilhes <jt@....hp.com> Cc: Johannes Berg <johannes@...solutions.net>, David Miller <davem@...emloft.net>, netdev@...r.kernel.org, linux-wireless@...r.kernel.org Subject: Re: [PATCH 9/9] net_device: dont include wext bits if not required On Thu, Apr 26, 2007 at 09:53:04AM -0700, Jean Tourrilhes wrote: > On Tue, Apr 24, 2007 at 08:07:41PM +0200, Johannes Berg wrote: > > This patch makes the wext bits in struct net_device depend on > > CONFIG_WIRELESS_EXT. > > > > Signed-off-by: Johannes Berg <johannes@...solutions.net> > > I personally would not do that. Having conditional fields in > "struct net_device" is very bad, it's a sure way to crash on modules > in some cases. If I remember well, Jeff Garzik has been fighting those > over the years. I'm not sure I understand the reasoning here. Without a doubt kernel modules need to be built against the same configuration as the kernels that are loading them. So, conditional component of net_device should not cause crashes. FWIW, there are other conditionally compiled portions of net_device (NETPOLL, NET_POLL_CONTROLLER). I don't see the harm here. John -- John W. Linville linville@...driver.com - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists