lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 27 Apr 2007 08:27:10 -0400 From: Jeff Garzik <jeff@...zik.org> To: Ayaz Abdulla <aabdulla@...dia.com> CC: akpm@...ux-foundation.org, netdev@...r.kernel.org, mingo@...e.hu Subject: Re: [patch 09/11] forcedeth: improve NAPI logic Ayaz Abdulla wrote: > > > Jeff Garzik wrote: >> Ayaz Abdulla wrote: >> >>> I don't see why the NAPI handler needs to process tx packets. The ISR >>> will handle all tx processing. >> >> >> It is a design choice, not a requirement. >> >> Moving non-RX interrupt processing to the NAPI handler can help as >> loads increase. The basic idea is to do as much work as possible in >> the NAPI handler with NIC interrupts masked. That mitigates global >> system per-interrupt overhead even more than an only-RX NAPI scheme. >> >> Several net drivers do TX completion handling in the NAPI handler. > > Ok. In that case, the patch needs to be improved. > > The following needs to be done when NAPI is enabled: > - remove the tx handling within the ISRs > - mask off the tx interrupts within the ISRs that handle tx processing > - re-enable tx interrupts within the NAPI handler > - add tx handling within the NAPI handler (this patch covers it) Agreed. Jeff - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists