netdev - Re: [patch 09/11] forcedeth: improve NAPI logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070427185716.GA5578@csclub.uwaterloo.ca>
Date:	Fri, 27 Apr 2007 14:57:16 -0400
From:	lsorense@...lub.uwaterloo.ca (Lennart Sorensen)
To:	Ayaz Abdulla <aabdulla@...dia.com>
Cc:	Jeff Garzik <jeff@...zik.org>, akpm@...ux-foundation.org,
	netdev@...r.kernel.org, mingo@...e.hu
Subject: Re: [patch 09/11] forcedeth: improve NAPI logic

On Thu, Apr 26, 2007 at 10:53:04AM -0400, Ayaz Abdulla wrote:
> Ok. In that case, the patch needs to be improved.
> 
> The following needs to be done when NAPI is enabled:
> - remove the tx handling within the ISRs
> - mask off the tx interrupts within the ISRs that handle tx processing
> - re-enable tx interrupts within the NAPI handler
> - add tx handling within the NAPI handler (this patch covers it)

I thought a number of drivers handled tx from napi while receives were
happening, but went to plain interrupts if no receives were happening.
Maybe I misread the code (I have mainly dealt with pcnet32 so far).
Certainly for gigabit I would think napi all the time would be much more
efficient.

--
Len Sorensen
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html