netdev - Re: [PATCH] fix smc911x compilation breakage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4633693B.7070404@pobox.com>
Date:	Sat, 28 Apr 2007 11:33:15 -0400
From:	Jeff Garzik <jgarzik@...ox.com>
To:	Vitaly Wool <vwool@...mvista.com>
CC:	dustin@...soria.com, netdev@...r.kernel.org,
	Russell King <rmk+lkml@....linux.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] fix smc911x compilation breakage

Vitaly Wool wrote:
> Hi Jeff,
> 
> currently (with 2.6.21) compilation of smc911x driver fails in the following way:
> 
>   CC      drivers/net/smc911x.o
> /sandbox/vital/opensource/linux-2.6/drivers/net/smc911x.c: In function `smc911x_probe':
> /sandbox/vital/opensource/linux-2.6/drivers/net/smc911x.c:2125: warning: implicit declaration of function `set_irq_type'
> /sandbox/vital/opensource/linux-2.6/drivers/net/smc911x.c:2125: error: `IRQ_TYPE_EDGE_FALLING' undeclared (first use in this function)
> /sandbox/vital/opensource/linux-2.6/drivers/net/smc911x.c:2125: error: (Each undeclared identifier is reported only once
> /sandbox/vital/opensource/linux-2.6/drivers/net/smc911x.c:2125: error: for each function it appears in.)
> make[3]: *** [drivers/net/smc911x.o] Error 1
> make[2]: *** [drivers/net] Error 2
> make[1]: *** [drivers] Error 2
> make: *** [zImage] Error 2
> 
> The patch inlined below fixes the problem.
> 
>  smc911x.c |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
> 
> Signed-off-by: Vitaly Wool <vitalywool@...il.com>
> 
> Index: linux-2.6/drivers/net/smc911x.c
> ===================================================================
> --- linux-2.6.orig/drivers/net/smc911x.c
> +++ linux-2.6/drivers/net/smc911x.c
> @@ -75,9 +75,9 @@ static const char version[] =
>  #include <linux/netdevice.h>
>  #include <linux/etherdevice.h>
>  #include <linux/skbuff.h>
> +#include <linux/irq.h>
>  
>  #include <asm/io.h>
> -#include <asm/irq.h>
>  
>  #include "smc911x.h"

This seems to clash with rmk's comment at the top of linux/irq.h?

	Jeff


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html