[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4638F0C4.2000406@freescale.com>
Date: Wed, 02 May 2007 15:12:52 -0500
From: Scott Wood <scottwood@...escale.com>
To: Kumar Gala <galak@...nel.crashing.org>
CC: jgarzik@...ox.com, netdev@...r.kernel.org, linuxppc-dev@...abs.org
Subject: Re: [PATCH v2] gianfar: Add I/O barriers when touching buffer descriptor
ownership.
Kumar Gala wrote:
> I'd rather see a wmb() instead of eieio() to keep this code non-ppc
> specific. (also, we implement wmb as eieio, so I don't keep the
> comment about it being too heavy, unless you mean generically).
wmb() is a sync, smp_wmb() is an eieio. Andy told me he would not
accept a sync in those spots.
And the driver is already ppc-specific; it uses in/out_be32.
-Scott
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists