lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 2 May 2007 15:20:25 -0500 From: Kumar Gala <galak@...nel.crashing.org> To: Scott Wood <scottwood@...escale.com> Cc: jgarzik@...ox.com, netdev@...r.kernel.org, linuxppc-dev@...abs.org Subject: Re: [PATCH v2] gianfar: Add I/O barriers when touching buffer descriptor ownership. On May 2, 2007, at 3:12 PM, Scott Wood wrote: > Kumar Gala wrote: >> I'd rather see a wmb() instead of eieio() to keep this code non- >> ppc specific. (also, we implement wmb as eieio, so I don't keep >> the comment about it being too heavy, unless you mean generically). > > wmb() is a sync, smp_wmb() is an eieio. Andy told me he would not > accept a sync in those spots. Sorry, was looking at the iobarrier code. > And the driver is already ppc-specific; it uses in/out_be32. True, but its hidden behind the gfar_read/write accessors. Your change is a bit more blatant. - k - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists