netdev - Re: [PATCH 17/20][BNX2]: Enhance the heartbeat.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070502.002426.38687430.davem@davemloft.net>
Date:	Wed, 02 May 2007 00:24:26 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jeff@...zik.org
Cc:	mchan@...adcom.com, netdev@...r.kernel.org
Subject: Re: [PATCH 17/20][BNX2]: Enhance the heartbeat.

From: Jeff Garzik <jeff@...zik.org>
Date: Wed, 02 May 2007 03:17:20 -0400

> Michael Chan wrote:
> > [BNX2]: Enhance the heartbeat.
> > 
> > In addition to the periodic heartbeat, we're adding a heartbeat
> > request interrupt when the heartbeat is late.  This is useful
> > especially in -rt kernels where the timer frequently runs late.
> > 
> > Signed-off-by: Michael Chan <mchan@...adcom.com>
> 
> Should we really be adding code for such a special situation to upstream 
> code?
> 
> I lean towards "no", but defer to your and DaveM's judgement here.

My understanding of this situation is that if the timer is delayed a
lot, which can happen with the -rt kernel, we don't send the heartbeat
ping to the chip within the required margin.

If the margin is not met, the ASF firmware takes this as a signal that
the host system is down, and does things like reset the network card
and other things we don't want it to do.

Clarification from Michael would be appreciated, for sure.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html