netdev - Re: [PATCH 5/11][TG3]: Remove reset during MAC address changes.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 05 May 2007 12:10:38 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	mchan@...adcom.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 5/11][TG3]: Remove reset during MAC address changes.

From: "Michael Chan" <mchan@...adcom.com>
Date: Fri, 04 May 2007 17:52:58 -0700

> [TG3]: Remove reset during MAC address changes.
> 
> The reset was added a while back so that ASF could re-init whatever
> MAC address it wanted to use after the MAC address was changed.
> Instead of resetting, we can just keep MAC address 1 unchanged during
> MAC address changes if MAC address 1 is different from MAC address 0.
> 
> This fixes 2 problems:
> 
> 1. Bonding calls set_mac_address in contexts that cannot sleep.
> It no longer sleeps with the chip reset removed.

This is arguably a bonding bug.

> 2. When ASF shares the same MAC address as the NIC, it needs to
> always do that even when the MAC address is changed. 
> 
> Signed-off-by: Michael Chan <mchan@...adcom.com>
> 

Applied, thanks.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html