netdev - Re: linkwatch bustage in git-net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 09 May 2007 00:18:14 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	akpm@...ux-foundation.org, netdev@...r.kernel.org
Subject: Re: linkwatch bustage in git-net

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Wed, 9 May 2007 17:16:15 +1000

> The real problem here is a combination of factors.  First of all e100
> does a netif_carrier_off in its open routine *before* the first call
> to dev_activate.  This when combined with the wrap-around bug causes
> an infinitely delayed event for your NIC to be installed.

I noticed that behavior of e100 too.

> [NET] link_watch: Always schedule urgent events
> 
> Urgent events may be delayed if we already have a non-urgent event
> queued for that device.  This patch changes this by making sure that
> an urgent event is always looked at immediately.
> 
> I've replaced the LW_RUNNING flag by LW_URGENT since whether work
> is scheduled is already kept track by the work queue system.
> 
> The only complication is that we have to provide some exclusion for
> the setting linkwatch_nextevent which is available in the actual
> work function.
> 
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

Thanks for working this out, applied and pushed to net-2.6.git
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html