netdev - Re: [PATCH] sched: Optimize return value of qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OF6A57F86D.C63329E8-ON652572D6.0027B2E9-652572D6.00289106@in.ibm.com>
Date:	Wed, 9 May 2007 12:53:05 +0530
From:	Krishna Kumar2 <krkumar2@...ibm.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] sched: Optimize return value of qdisc_restart

David Miller <davem@...emloft.net> wrote on 05/09/2007 12:06:30 PM:

> But this only makes sense for the second hunk you changed.

I think it should work fine for both.

> The first hunk is a bug case, an improper looping device
> decapsulation condition, and we do want to always return
> -1 in that case in order to break out of the loop.

I guess you meant "we do *not* want to always return -1" ?

> Your change will make the kernel essentially hang instead
> when this bug check is triggered.

By returning -1, we end up freeing all the skbs one by one, or
until the condition : "transient error caused by hard_start_xmit
recursing" is over. Essentially, that behavior is also not
changed in my patch (only run time change is to return 0 if
there are no more skbs).

Thanks,

- KK

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html