netdev - Re: [PATCH] sched: Optimize return value of qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070509.011201.68040843.davem@davemloft.net>
Date:	Wed, 09 May 2007 01:12:01 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	krkumar2@...ibm.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] sched: Optimize return value of qdisc_restart

From: Krishna Kumar2 <krkumar2@...ibm.com>
Date: Wed, 9 May 2007 12:53:05 +0530

> David Miller <davem@...emloft.net> wrote on 05/09/2007 12:06:30 PM:
> 
> > Your change will make the kernel essentially hang instead
> > when this bug check is triggered.
> 
> By returning -1, we end up freeing all the skbs one by one, or
> until the condition : "transient error caused by hard_start_xmit
> recursing" is over. Essentially, that behavior is also not
> changed in my patch (only run time change is to return 0 if
> there are no more skbs).

Something this evening is obviously making it impossible
for my brain to understand this function and your patch,
so I'm going to sleep on it and try again tomorrow :-)
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html