netdev - Re: [PATCH] sched: Optimize return value of qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 10 May 2007 14:11:36 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	herbert@...dor.apana.org.au
Cc:	krkumar2@...ibm.com, hadi@...erus.ca, netdev@...r.kernel.org
Subject: Re: [PATCH] sched: Optimize return value of qdisc_restart

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Thu, 10 May 2007 22:10:10 +1000

> On Thu, May 10, 2007 at 04:55:34AM -0700, David Miller wrote:
> >
> > > [NET_SCHED]: Rationalise return value of qdisc_restart
> > 
> > Fair enough, patch applied :-)
> 
> Sorry, reading Thomas's patch made me realise that I've just added
> that bug all over again.
> 
> [NET_SCHED]: Reread dev->qdisc for NETDEV_TX_OK
> 
> Now that we return the queue length after NETDEV_TX_OK we better
> make sure that we have the right queue.  Otherwise we can cause a
> stall after a really quick dev_deactive/dev_activate.
> 
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

:-) Applied.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html