netdev - Re: [PATCH] sched: Optimize return value of qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070510143103.GA27261@gondor.apana.org.au>
Date:	Fri, 11 May 2007 00:31:04 +1000
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Krishna Kumar2 <krkumar2@...ibm.com>
Cc:	hadi@...erus.ca, davem@...emloft.net, netdev@...r.kernel.org,
	Roberto Nibali <ratz@...gphish.ch>, Thomas Graf <tgraf@...g.ch>
Subject: Re: [PATCH] sched: Optimize return value of qdisc_restart

On Thu, May 10, 2007 at 07:56:02PM +0530, Krishna Kumar2 wrote:
> 
> Herbert,
> 
> -            while (qdisc_restart(dev) < 0 && !netif_queue_stopped(dev))
> -                        /* NOTHING */;
> +            do {
> +                        if (!qdisc_restart(dev))
> +                                    break;
> +            } while (!netif_queue_stopped(dev));
> 
> This could be changed to old format, if required :
> 
> +            while (qdisc_restart(dev)) && !netif_queue_stopped(dev))
> +                 /* NOTHING */;

Actually I deliberately changed it so that it's slightly clearer.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html