netdev - Re: [PATCH] phylib: phy_ethtool_{sset,gset} -- check phydev for NULL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8496f91a0705110649w2f42c26fi65db0d92fb8bdfd8@mail.gmail.com>
Date:	Fri, 11 May 2007 17:49:19 +0400
From:	"Matvejchikov Ilya" <matvejchikov@...il.com>
To:	"Kumar Gala" <galak@...nel.crashing.org>
Cc:	"Jeff Garzik" <jeff@...zik.org>,
	"Randy Dunlap" <randy.dunlap@...cle.com>, netdev@...r.kernel.org
Subject: Re: [PATCH] phylib: phy_ethtool_{sset,gset} -- check phydev for NULL

2007/5/11, Kumar Gala <galak@...nel.crashing.org>:
>
> On May 11, 2007, at 5:58 AM, Matvejchikov Ilya wrote:
>
> > Signed-off-by: Matvejchikov Ilya <matvejchikov@...il.com>
> > ---
> >
> > diff -purN linux-2.6.21-clean/drivers/net/phy/phy.c
> > linux-2.6.21/drivers/net/phy/phy.c
> > --- linux-2.6.21-clean/drivers/net/phy/phy.c  2007-04-26
> > 07:08:32.000000000 +0400
> > +++ linux-2.6.21/drivers/net/phy/phy.c        2007-05-04
> > 08:22:01.000000000 +0400
> > @@ -245,6 +245,9 @@ EXPORT_SYMBOL(phy_sanitize_settings);
> >  */
> > int phy_ethtool_sset(struct phy_device *phydev, struct ethtool_cmd
> > *cmd)
> > {
> > +     if (unlikely(!phydev))
> > +             return -EINVAL;
>
> Should this be -ENODEV?

If we get the ENODEV error, we are suppose that there is no device at
all. PHY device may not be connected to the NET device. But if it
exists we can't say that there is NODEV...

I think it should be -EINVAL.

> > +
> >       if (cmd->phy_address != phydev->addr)
> >               return -EINVAL;
> >
> > @@ -289,6 +292,9 @@ EXPORT_SYMBOL(phy_ethtool_sset);
> >
> > int phy_ethtool_gset(struct phy_device *phydev, struct ethtool_cmd
> > *cmd)
> > {
> > +     if (unlikely(!phydev))
> > +             return -EINVAL;
>
> same question.

The same answer :)

> > +
> >       cmd->supported = phydev->supported;
> >
> >       cmd->advertising = phydev->advertising;
> > -
> > To unsubscribe from this list: send the line "unsubscribe netdev" in
> > the body of a message to majordomo@...r.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html