[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <39e6f6c70705161351i249715ud7a4cc317d9677bc@mail.gmail.com>
Date: Wed, 16 May 2007 17:51:01 -0300
From: "Arnaldo Carvalho de Melo" <acme@...stprotocols.net>
To: "Urs Thuermann" <urs@...ogud.escape.de>
Cc: netdev@...r.kernel.org, "Thomas Gleixner" <tglx@...utronix.de>,
"Oliver Hartkopp" <oliver.hartkopp@...kswagen.de>
Subject: Re: [patch 2/7] CAN: Add PF_CAN core module
On 16 May 2007 21:14:20 +0200, Urs Thuermann <urs@...ogud.escape.de> wrote:
> "Arnaldo Carvalho de Melo" <acme@...stprotocols.net> writes:
>
> > Can can_ifindex be turned into a unsigned short? That way we would
> > have it nicely packed, avoiding this hole:
>
> Since dev->ifindex is int and we have many assignments between
> can_ifindex and dev->ifindex it would not make sense to define
> can_ifindex as a short int. Also in user space, ifindex is int,
> e.g. in struct ifreq. This would cause implicit truncating type casts
> from int to short int (some compilers warn about this, haven't tried
> GCC for a long time) or require many explicit type casts.
Quick answer, thank you.
- Arnaldo
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists