netdev - Re: [patch 2/7] CAN: Add PF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ygfsl9wfunn.fsf@janus.isnogud.escape.de>
Date:	16 May 2007 21:14:20 +0200
From:	Urs Thuermann <urs@...ogud.escape.de>
To:	"Arnaldo Carvalho de Melo" <acme@...stprotocols.net>
Cc:	netdev@...r.kernel.org, "Thomas Gleixner" <tglx@...utronix.de>,
	"Oliver Hartkopp" <oliver.hartkopp@...kswagen.de>
Subject: Re: [patch 2/7] CAN: Add PF_CAN core module

"Arnaldo Carvalho de Melo" <acme@...stprotocols.net> writes:

> Can can_ifindex be turned into a unsigned short? That way we would
> have it nicely packed, avoiding this hole:

Since dev->ifindex is int and we have many assignments between
can_ifindex and dev->ifindex it would not make sense to define
can_ifindex as a short int.  Also in user space, ifindex is int,
e.g. in struct ifreq.  This would cause implicit truncating type casts
from int to short int (some compilers warn about this, haven't tried
GCC for a long time) or require many explicit type casts.

urs
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html