netdev - Re: [PATCH] e1000: Work around 82571 completion timout on Pseries HW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <AB70342E-4617-428C-81D1-78EF74982B3C@kernel.crashing.org>
Date:	Thu, 17 May 2007 08:10:41 -0500
From:	Kumar Gala <galak@...nel.crashing.org>
To:	Christoph Hellwig <hch@...radead.org>
Cc:	Auke Kok <auke-jan.h.kok@...el.com>, jeff@...zik.org,
	wenxiong@...ibm.com, e1000-devel@...ts.sourceforge.net,
	netdev@...r.kernel.org
Subject: Re: [PATCH] e1000: Work around 82571 completion timout on Pseries HW


On May 17, 2007, at 4:01 AM, Christoph Hellwig wrote:

> On Wed, May 16, 2007 at 07:43:27PM -0500, Kumar Gala wrote:
>>> index 49be393..830d851 100644
>>> --- a/drivers/net/e1000/e1000_main.c
>>> +++ b/drivers/net/e1000/e1000_main.c
>>> @@ -819,6 +819,16 @@ e1000_reset(struct e1000_adapter *adapter)
>>> 		E1000_WRITE_REG(&adapter->hw, CTRL, ctrl);
>>> 	}
>>>
>>> +#if defined(CONFIG_PPC64) || defined(CONFIG_PPC)
>>
>> If this is really on need on pseries HW this should be #ifdef
>> CONFIG_PPC_PSERIES.  No reason to force this on all PPC.
>
> No, it shouldn't.  powerpc kernels are multi-platform.

Right, but if you build a multi-platform kernel with pseries support  
you'll get CONFIG_PPC_PSERIES set.

> It really shouldn't be there at all because something in either the  
> intel
> or pseries hardware is totally buggy and we should disable features in
> the buggy one completely.

Agreed.

- k
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html