netdev - Re: [PATCH] ixgb: don't print error if pci_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <464CF75A.8000600@garzik.org>
Date:	Thu, 17 May 2007 20:46:18 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Auke Kok <auke-jan.h.kok@...el.com>
CC:	netdev@...r.kernel.org, e1000-devel@...ts.sourceforge.net,
	jesse.brandeburg@...el.com, john.ronciak@...el.com,
	jeffrey.t.kirsher@...el.com, cebbert@...hat.com, hpa@...or.com
Subject: Re: [PATCH] ixgb: don't print error if pci_enable_msi() fails, cleanup
 minor leak

Auke Kok wrote:
> From: Auke Kok <auke-jan.h.kok@...el.com>
> 
> pci_enable_msi calls can fail for normal operational reasons. Driver
> should not print an error message in that case. Fix a leak that leaves
> msi enabled if pci_request_irq fails. We can remove CONFIG_PCI_MSI
> ifdefs alltogether
> 
> Signed-off-by: Auke Kok <auke-jan.h.kok@...el.com>
> ---
> 
>  drivers/net/ixgb/ixgb.h      |    2 --
>  drivers/net/ixgb/ixgb_main.c |   36 +++++++++++++++---------------------
>  2 files changed, 15 insertions(+), 23 deletions(-)

applied


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html