netdev - Re: [PATCH] e1000: Fix msi enable leak on error, don't print error message, cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <464CF763.5040306@garzik.org>
Date:	Thu, 17 May 2007 20:46:27 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Auke Kok <auke-jan.h.kok@...el.com>
CC:	netdev@...r.kernel.org, e1000-devel@...ts.sourceforge.net,
	hpa@...or.com
Subject: Re: [PATCH] e1000: Fix msi enable leak on error, don't print error
 message,	cleanup

Auke Kok wrote:
> pci_enable_msi failure is a normal event so we should not print any error.
> Going over the code I spotted a missing pci_disable_msi() leak when irq
> allocation fails. The whole code also needed a cleanup, so I combined the
> two different calls to pci_request_irq into a single call making this
> look a lot better. All #ifdef CONFIG_PCI_MSI's have been removed.
> 
> Compile tested with both CONFIG_PCI_MSI enabled and disabled.
> 
> Signed-off-by: Auke Kok <auke-jan.h.kok@...el.com>
> Cc: H. Peter Anvin <hpa@...or.com>
> ---
> 
>  drivers/net/e1000/e1000.h      |    4 +---
>  drivers/net/e1000/e1000_main.c |   39 ++++++++++++++-------------------------
>  2 files changed, 15 insertions(+), 28 deletions(-)

applied


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html