netdev - Re: [Cbe-oss-dev] [PATCH 2/10] spidernet: beautify error messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 18 May 2007 12:08:38 -0500
From:	linas@...tin.ibm.com (Linas Vepstas)
To:	Michael Ellerman <michael@...erman.id.au>
Cc:	Jeff Garzik <jgarzik@...ox.com>, netdev@...r.kernel.org,
	cbe-oss-dev@...abs.org
Subject: Re: [Cbe-oss-dev] [PATCH 2/10] spidernet: beautify error messages

On Thu, May 17, 2007 at 09:28:53AM +1000, Michael Ellerman wrote:
> On Wed, 2007-05-16 at 17:00 -0500, Linas Vepstas wrote:
> > -			pr_err("Not enough memory to allocate rx buffer\n");
> > +			pr_err("%s: Not enough memory to allocate rx buffer\n",
> > +			    card->netdev->name);
> 
> Isn't that what dev_err() is for?

Ahh, did not know that. These patches just got pushed upstream, I'll send 
a separate round to clean this up.

--linas


-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html