lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 22 May 2007 18:35:18 -0500 From: linas@...tin.ibm.com (Linas Vepstas) To: Michael Ellerman <michael@...erman.id.au> Cc: Jeff Garzik <jgarzik@...ox.com>, netdev@...r.kernel.org, cbe-oss-dev@...abs.org Subject: Re: [Cbe-oss-dev] [PATCH 4/10] spidernet: zero out a pointer. On Thu, May 17, 2007 at 09:32:56AM +1000, Michael Ellerman wrote: > > + hwdescr->buf_addr = 0x0; > > If you're going to be paranoid, shouldn't you do something here to make > sure the value's hit the device? I thought the whole point of paranoia is that its inexplicable. Here's a delusional reply: I didn't see any point to it. 1) a wmb would add overhead 2) the hardware is supposed to be looking at the status flag, anyway, and not misbehaving. 3) there is a wmb when the descr is actually refilled in such a way as to actually mean something to the hardware. All that I really acomplished here is a minor trick to aid in debug printing when looking for something bad. --linas - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists